New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading and storing Decimal #171

Merged
merged 2 commits into from May 30, 2018

Conversation

3 participants
@tholo
Copy link
Contributor

tholo commented May 8, 2018

Add initializer to MySQLData for Decimal values and a MySQLDataConvertible extension on Decimal so it can be converted from and to string-form as expected by MYSQL_TYPE_{,NEW}DECIMAL.

Add support for loading and storing Decimal
Add initializer to MySQLData for Decimal values and a
MySQLDataConvertible extension on Decimal so it can be
converted from and to string-form as expected by
MYSQL_TYPE_{,NEW}DECIMAL.
@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented May 8, 2018

We just need to add an extra case right here to support the decimal type.

Allow decoding MySQL decimal to numbers
Add a case to allow MySQL decimals to be decoded into floats
and integers of various sizes as well. Suggestion by @Tanner
@tholo

This comment has been minimized.

Copy link
Contributor Author

tholo commented May 17, 2018

So did add that case (for integers) as well as a similar one for floats...

@tanner0101
Copy link
Member

tanner0101 left a comment

Great, thanks!

@tanner0101 tanner0101 added this to the 3.0.0-rc.2.3 milestone May 30, 2018

@tanner0101 tanner0101 self-assigned this May 30, 2018

@tanner0101 tanner0101 merged commit de21b1d into vapor:master May 30, 2018

4 of 5 checks passed

ci/circleci: 8.0-linux-fluent Your tests failed on CircleCI
Details
ci/circleci: 5.5-linux Your tests passed on CircleCI!
Details
ci/circleci: 5.7-linux Your tests passed on CircleCI!
Details
ci/circleci: 8.0-linux Your tests passed on CircleCI!
Details
ci/circleci: linux-release Your tests passed on CircleCI!
Details
@penny-coin

This comment has been minimized.

Copy link

penny-coin commented May 30, 2018

Hey @tholo, you just merged a pull request, have a coin!

You now have 2 coins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment