Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace fatalErrors() by throwing errors #15
Conversation
labradon
added some commits
Feb 12, 2018
tanner0101
added this to the 1.0.0-beta.2 milestone
Feb 14, 2018
tanner0101
added
the
enhancement
label
Feb 14, 2018
tanner0101
self-assigned this
Feb 14, 2018
tanner0101
approved these changes
Feb 14, 2018
Awesome! Thank you |
tanner0101
merged commit 80554b2
into
vapor:beta
Feb 14, 2018
tanner0101
added this to Done
in Vapor 3
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
labradon commentedFeb 12, 2018
•
edited
Replaced a lot of fatalErrors by throwing
PostgreSQLError
s when possible.Also removed the
infix operator !!
by throwing the corresponding error if a guard statement fails.This closes #14.