New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close a `PostgreSQLConnection`'s channel on deinit. #36

Merged
merged 1 commit into from Mar 21, 2018

Conversation

2 participants
@MrMage
Copy link
Contributor

MrMage commented Mar 20, 2018

Otherwise, the connection is never claused, and PostgreSQL might complain about too many open connections.

Close a `PostgreSQLConnection`'s channel on deinit.
Otherwise, the connection is never claused, and PostgreSQL might complain about too many open connections.

@tanner0101 tanner0101 added this to the 1.0.0-rc.2 milestone Mar 21, 2018

@tanner0101 tanner0101 added the bug label Mar 21, 2018

@tanner0101 tanner0101 self-assigned this Mar 21, 2018

@tanner0101 tanner0101 merged commit e4d26fd into nio Mar 21, 2018

1 check failed

ci/circleci: linux Your tests failed on CircleCI
Details
@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Mar 21, 2018

thanks!

@tanner0101 tanner0101 deleted the close-connection-on-deinit branch Mar 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment