Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upClose a `PostgreSQLConnection`'s channel on deinit. #36
Conversation
tanner0101
added this to the 1.0.0-rc.2 milestone
Mar 21, 2018
tanner0101
added
the
bug
label
Mar 21, 2018
tanner0101
self-assigned this
Mar 21, 2018
tanner0101
merged commit e4d26fd
into
nio
Mar 21, 2018
1 check failed
ci/circleci: linux
Your tests failed on CircleCI
Details
This comment has been minimized.
This comment has been minimized.
|
thanks! |
tanner0101
deleted the
close-connection-on-deinit
branch
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MrMage commentedMar 20, 2018
Otherwise, the connection is never claused, and PostgreSQL might complain about too many open connections.