New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent 1.0.0 gm, add decoders + sql updates #72

Merged
merged 34 commits into from Jun 15, 2018

Conversation

4 participants
@tanner0101
Copy link
Member

tanner0101 commented May 31, 2018

No description provided.

@tanner0101 tanner0101 added this to the 1.0.0 milestone May 31, 2018

@tanner0101 tanner0101 self-assigned this May 31, 2018

tanner0101 added some commits May 31, 2018

tanner0101 added some commits Jun 2, 2018

@tanner0101 tanner0101 referenced this pull request Jun 2, 2018

Closed

query.sum() doesn't work #56

tanner0101 added some commits Jun 2, 2018

@hyouuu

This comment has been minimized.

Copy link

hyouuu commented Jun 5, 2018

Any timeline to merge this? Or should I start pointing to this branch? Just tried doing .package(url: "https://github.com/vapor/fluent-postgresql.git", .branch("gm")), but compiling gave lots of errors:

screen shot 2018-06-05 at 1 55 50 pm

tanner0101 added some commits Jun 6, 2018

@tanner0101 tanner0101 changed the title fluent 3.0.0 gm, add decoders + sql updates fluent 1.0.0 gm, add decoders + sql updates Jun 6, 2018

tanner0101 added some commits Jun 6, 2018

@Cellane
Copy link
Contributor

Cellane left a comment

Just a few small things I noticed.

/// Creates a new `PostgreSQLDatabaseConfig`.
public init(serverAddress: ServerAddress, username: String, database: String? = nil, password: String? = nil, transport: PostgreSQLTransportConfig = .cleartext) {
self.serverAddress = serverAddress
public init(serverAddress: PostgreSQLConnection.ServerAddress, username: String, database: String? = nil, password: String? = nil, transport: PostgreSQLConnection.TransportConfig = .cleartext) {

This comment has been minimized.

@Cellane

Cellane Jun 9, 2018

Contributor

A cosmetic thing but the indentation is wrong for this method, somehow tabs sneaked into a project indented by spaces.

guard let url = URL(string: urlString),
let hostname = url.host,
let port = url.port,
let username = url.user,
let database = url.databaseName,
url.path.count > 0

This comment has been minimized.

@Cellane

Cellane Jun 9, 2018

Contributor

This check (url.path.count > 0) is probably not necessary since the previous line will already guarantee that database name was supplied as a part of the connection string?

tanner0101 added some commits Jun 15, 2018

@penny-coin

This comment has been minimized.

Copy link

penny-coin commented Jun 15, 2018

Hey @tanner0101, you just merged a pull request, have a coin!

You now have 705 coins.

@tanner0101 tanner0101 merged commit 0d35a22 into master Jun 15, 2018

1 of 3 checks passed

ci/circleci: linux-fluent Your tests failed on CircleCI
Details
ci/circleci: linux-release CircleCI is running your tests
Details
ci/circleci: linux Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 deleted the gm branch Jun 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment