/vapor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Request` -> `RequestContext` #1443

Closed
mcdappdev opened this Issue Jan 22, 2018 · 7 comments

Comments

Assignees

@tanner0101 tanner0101

Labels
enhancement
Projects
None yet
Milestone
  3.0.0
4 participants
@mcdappdev @0xTim @twof @tanner0101
@mcdappdev
Copy link
Member

mcdappdev commented Jan 22, 2018

For better clarity between Request and HTTPRequest

@tanner0101 tanner0101 added this to the 3.0.0 milestone Jan 22, 2018

@tanner0101 tanner0101 added the enhancement label Jan 22, 2018

@tanner0101 tanner0101 self-assigned this Jan 22, 2018

@0xTim

This comment has been minimized.

Sign in to view
Copy link
Member

0xTim commented Jan 22, 2018

Should this be Request -> RequestContext or is it just Response or is it both?
@twof

This comment has been minimized.

Sign in to view
Copy link
Member

twof commented Jan 22, 2018

It should definitely be Request -> RequestContext
@mcdappdev

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcdappdev commented Jan 22, 2018

Oh yeah good catch, thanks.

@0xTim 0xTim changed the title `Response` -> `ResponseContext` `Request` -> `RequestContext` Jan 22, 2018

@0xTim

This comment has been minimized.

Sign in to view
Copy link
Member

0xTim commented Jan 22, 2018

@mcdappdev I've updated the title, feel free to change if it is something else!
@mcdappdev

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcdappdev commented Jan 22, 2018

No that's perfect, thank you!

@tanner0101 tanner0101 added this to Backlog in Vapor 3 Feb 12, 2018

@tanner0101

This comment has been minimized.

Sign in to view
Copy link
Member

tanner0101 commented Feb 22, 2018

We'll need to postpone discussion on this one until Vapor 4. Even if we acted on this in January it would have been a bit too late. I'm open for other ideas on how we can clarify the difference between Vapor.Request and HTTP.HTTPRequest via docs or otherwise. Thanks @mcdappdev.

@tanner0101 tanner0101 closed this Feb 22, 2018

@mcdappdev

This comment has been minimized.

Sign in to view
Copy link
Member Author

mcdappdev commented Feb 22, 2018

No problem 👍🏻

@Joannis Joannis moved this from Backlog to Done in Vapor 3 Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment