New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate makeResponse() in favour of response() #1671

Closed
jamiebishop opened this Issue May 9, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@jamiebishop
Copy link
Contributor

jamiebishop commented May 9, 2018

I believe that req.makeResponse() should be deprecated, in favour of req.response().

  • The latter reads much nicer: e.g return req.response() instead of return req.makeResponse().

This would be introduced in Vapor 3.1, and makeResponse would be marked as deprecated.

@jamiebishop jamiebishop referenced this issue May 9, 2018

Merged

Rename makeResponse to response #1672

4 of 4 tasks complete
@rafiki270

This comment has been minimized.

Copy link
Contributor

rafiki270 commented May 13, 2018

Feature has been already merged into master

@rafiki270 rafiki270 closed this May 13, 2018

@nullpixel

This comment has been minimized.

Copy link

nullpixel commented May 14, 2018

it's on the 3.1 branch for now, by the looks of it

@tanner0101 tanner0101 added this to the 3.1.0 milestone May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment