Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value of last .env file line is truncated #2220

Closed
tarag opened this issue Mar 6, 2020 · 0 comments · Fixed by #2225
Closed

Value of last .env file line is truncated #2220

tarag opened this issue Mar 6, 2020 · 0 comments · Fixed by #2225
Labels
bug Something isn't working
Projects
Vapor 4

Comments

@tarag
Copy link

tarag commented Mar 6, 2020

Last character on the last line of .env file is truncated if line is not newline terminated.

Steps to reproduce

Example .env file:
CLIENT_SECRET= 043cfc7a1fcb5295ccc67bb392ba1d5478fb2c04e6ca32442186a15fff787dbf
CLIENT_ID= 968bc2d15f547b8473a213a9fbaacd0f39345859f6eea65563b9603563626c03 <NO \n here>

Expected behavior

Environment.get("CLIENT_ID") equals "968bc2d15f547b8473a213a9fbaacd0f39345859f6eea65563b9603563626c03"

Actual behavior

Environment.get("CLIENT_ID") equals "968bc2d15f547b8473a213a9fbaacd0f39345859f6eea65563b9603563626c0"

Environment

  • Vapor Framework version: 4.0.0-rc.1.3
  • Vapor Toolbox version: 3.1.10
  • OS version: 10.15.3
@tarag tarag changed the title Character truncated in value of last .env file line Value of last .env file line is truncated Mar 6, 2020
@tanner0101 tanner0101 added the bug Something isn't working label Mar 6, 2020
@tanner0101 tanner0101 added this to To Do in Vapor 4 via automation Mar 6, 2020
@tanner0101 tanner0101 mentioned this issue Mar 6, 2020
Merged
Vapor 4 automation moved this from To Do to Done Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix .env parsing with no trailing newline vapor/vapor
2 participants
@tanner0101 @tarag