New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Router.on method public #1528

merged 1 commit into from Feb 28, 2018


2 participants
Copy link

calebkleveter commented Feb 27, 2018


  • Circle CI is passing (code compiles and passes tests).
  • There are no breaking changes to public API.
  • New test cases have been added where appropriate.
  • All new code has been commented with doc blocks ///.

@tanner0101 tanner0101 self-assigned this Feb 28, 2018


This comment has been minimized.

Copy link

tanner0101 commented Feb 28, 2018

Thanks @calebkleveter 👍

@SandorDobi, IIRC you could also use this!

@tanner0101 tanner0101 merged commit 49ef12b into vapor:beta Feb 28, 2018

1 check passed

ci/circleci: linux Your tests passed on CircleCI!

@tanner0101 tanner0101 added this to the 3.0.0-rc.2 milestone Feb 28, 2018

@calebkleveter calebkleveter deleted the calebkleveter:public-generic-route branch Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment