New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to see if path is a directory as well #1560

Merged
merged 2 commits into from Mar 22, 2018

Conversation

2 participants
@0xTim
Copy link
Member

0xTim commented Mar 22, 2018

Fixes #1559

@0xTim 0xTim requested a review from tanner0101 Mar 22, 2018

@0xTim

This comment has been minimized.

Copy link
Member Author

0xTim commented Mar 22, 2018

Also fixes the CI pipeline

@tanner0101 tanner0101 added this to the 3.0.0-rc.2.0.1 milestone Mar 22, 2018

@tanner0101 tanner0101 added the bug label Mar 22, 2018

@tanner0101 tanner0101 self-assigned this Mar 22, 2018

@tanner0101
Copy link
Member

tanner0101 left a comment

LGTM (Although I'd love to see a test for it as well)

@tanner0101 tanner0101 merged commit dc05167 into master Mar 22, 2018

2 checks passed

ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-api-template Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 deleted the filemiddleware-dir-bug branch Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment