/vapor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use environment for command line arguments #1570

Merged
merged 3 commits into from Mar 25, 2018

Conversation

Reviewers
No reviews
Assignees

@tanner0101 tanner0101

Labels
enhancement
Projects
  
Vapor 3 (awaiting triage)
Milestone
  3.0.0-rc.2.2
1 participant
@tanner0101
@tanner0101
Copy link
Member

tanner0101 commented Mar 24, 2018 •
edited

  • move to using the Environment.commandLine property for accessing CLI arguments. An improvement over using a statically available property that could create issues for projects with multiple applications.
  • Adds runningServer property.
  • Adds asyncBoot and asyncRun methods to Application
  • relies on vapor/console#60
  • relies on vapor/service#20

@tanner0101 tanner0101 added the enhancement label Mar 24, 2018

@tanner0101 tanner0101 added this to the 3.0.0-rc.2.2 milestone Mar 24, 2018

@tanner0101 tanner0101 self-assigned this Mar 24, 2018

tanner0101 added some commits Mar 25, 2018

@tanner0101
async run + running server
Loading status checks…
5be9b4e
@tanner0101
remove fatalerror
Loading status checks…
845562d

@tanner0101 tanner0101 merged commit 72424e7 into master Mar 25, 2018
2 checks passed

2 checks passed

ci/circleci: linux Your tests passed on CircleCI!
Details
ci/circleci: linux-api-template Your tests passed on CircleCI!
Details

@tanner0101 tanner0101 deleted the env-cli branch Mar 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment