Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative percent decoding in FileMiddleware #2500

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Fix relative percent decoding in FileMiddleware #2500

merged 1 commit into from
Sep 30, 2020

Conversation

tanner0101
Copy link
Member

@tanner0101 tanner0101 commented Sep 30, 2020 •
edited
Loading

Fixes an issue preventing FileMiddleware from detecting relative paths when percent encoded (#2500).

@tanner0101 tanner0101 added bug Something isn't working semver-patch Internal changes only labels Sep 30, 2020
@tanner0101 tanner0101 added this to Awaiting Review in Vapor 4 via automation Sep 30, 2020
gwynne
gwynne approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanner0101 tanner0101 merged commit cf1651f into master Sep 30, 2020
Vapor 4 automation moved this from Awaiting Review to Done Sep 30, 2020
@tanner0101 tanner0101 deleted the tn-relative-percent-decode-file branch September 30, 2020 23:28
@tanner0101
Copy link
Member Author

These changes are now available in 4.29.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
bug Something isn't working semver-patch Internal changes only
Projects
Vapor 4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tanner0101 @gwynne