-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URLEncodedFormEncoder encoding rules #3192
Conversation
var allowed = CharacterSet.alphanumerics | ||
allowed.insert(charactersIn: "*-._") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly not sure why this is allowing [
and ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally because of Vapor's support for "array" URL parameters, but that doesn't matter for this usage.
$
in URLEncodedFormEncoderDate(timeIntervalSince1970: 10_000), | ||
Date(timeIntervalSince1970: 20_000), | ||
Date(timeIntervalSince1970: 30_000), | ||
Date(timeIntervalSince1970: 40_000), | ||
Date(timeIntervalSince1970: 50_000), | ||
Date(timeIntervalSince1970: 10000), | ||
Date(timeIntervalSince1970: 20000), | ||
Date(timeIntervalSince1970: 30000), | ||
Date(timeIntervalSince1970: 40000), | ||
Date(timeIntervalSince1970: 50000), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, turn down the settings on your code formatter, this is a change for the worse 🤣
These changes are now available in 4.100.1
Solves #3173
References https://url.spec.whatwg.org/#application-x-www-form-urlencoded-percent-encode-set to set the encoding rules