New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra HTTPHeaders to WebSocket client #2

Merged
merged 3 commits into from Apr 26, 2018

Conversation

2 participants
@pvels
Copy link
Contributor

pvels commented Apr 19, 2018

No description provided.

@pvels pvels force-pushed the pvels:master branch from 9fc91ee to b39ab04 Apr 19, 2018

@tanner0101
Copy link
Member

tanner0101 left a comment

good change 👍

@@ -31,9 +31,10 @@ extension HTTPClient {
hostname: String,
port: Int? = nil,
path: String = "/",
headers: HTTPHeaders = .init(),

This comment has been minimized.

@tanner0101

tanner0101 Apr 20, 2018

Member

docblock needs to be adjusted for this new param

This comment has been minimized.

@pvels

pvels Apr 21, 2018

Author Contributor

done 🙂

@tanner0101 tanner0101 self-assigned this Apr 20, 2018

@pvels pvels force-pushed the pvels:master branch from 88b1a49 to be37e7b Apr 21, 2018

@tanner0101 tanner0101 added this to the 1.0.1 milestone Apr 26, 2018

@tanner0101

This comment has been minimized.

Copy link
Member

tanner0101 commented Apr 26, 2018

thanks!

@tanner0101 tanner0101 merged commit ea680cd into vapor:master Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment