From 25ba9c18913ea91b9cdbea18fd1407309d992f3f Mon Sep 17 00:00:00 2001
From: Oliver Stolpe <oliver.stolpe@bih-charite.de>
Date: Thu, 4 Aug 2022 18:16:39 +0200
Subject: [PATCH] Form template reports error if genomebuild variable is not
 set. (#609)

Closes: #607
Related-Issue: #607
Projected-Results-Impact: none
---
 HISTORY.rst                                   |  5 +--
 .../variants/filter_form/frequency.html       | 32 +++++++++++++++----
 2 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/HISTORY.rst b/HISTORY.rst
index f09364152..873950dd5 100644
--- a/HISTORY.rst
+++ b/HISTORY.rst
@@ -12,6 +12,7 @@ End-User Summary
 - Add Transcripts GnomadAD constraints and clinvar reports in the export(#568)
 - Extra annotations in export completed and tested (#495).
 - Fixed bug where Exac and thousand genomes settings were not shown in frequency tab for GRCh37 (#597).
+- Form template reports error if genomebuild variable is not set (#607).
 
 Full Change List
 ================
@@ -19,10 +20,10 @@ Full Change List
 - Extra annotations in export completed and tested (#495).
 - Fixing issue with sync-from-remote when no remote is defined (#570).
 - Fixed bug where Exac and thousand genomes settings were not shown in frequency tab for GRCh37 (#597).
-
+- Form template reports error if genomebuild variable is not set (#607).
 
 -----------------
-v1.2.2 (anthenea)
+v1.2.1 (anthenea)
 -----------------
 
 End-User Summary
diff --git a/variants/templates/variants/filter_form/frequency.html b/variants/templates/variants/filter_form/frequency.html
index f5335760a..0b6055ceb 100644
--- a/variants/templates/variants/filter_form/frequency.html
+++ b/variants/templates/variants/filter_form/frequency.html
@@ -9,7 +9,16 @@
   The checkboxes enable (<i class="iconify" data-icon="fa-regular:check-square"></i>) or disable (<i class="iconify" data-icon="fa-regular:square"></i>) filtration based on the population frequencies of the given database.
   You can provide the number of carriers with maximal heterozygous/homozygous (respectively: -plasmid) state or population frequencies.
   For the in-house DB, you can only filter based on carrier state as currently it is tracked how many carriers have sufficient coverage for each variant.
-  {% if genomebuild != "GRCh37" %}Thousand genomes and ExAC frequencies are only available GRCh37 cases.{% endif %}
+  {% if genomebuild == "GRCh37" %}
+  {% elif genomebuild == "GRCh38" %}
+    Thousand genomes and ExAC frequencies are only available GRCh37 cases.
+  {% else %}
+    <div class="alert alert-danger">
+      <i class="iconify" data-icon="bi:exclamation-circle"></i>
+      Genomebuild variable is unknown (<strong>{{ genomebuild }}</strong>).
+      The form might not be displayed correctly.
+    </div>
+  {% endif %}
 </div>
 
 <table class="table table-striped table-hover sodar-card-table compact-form-groups">
@@ -24,10 +33,14 @@
     </tr>
   </thead>
   <tbody>
-    <tr>
-      <td colspan="6">{{ genomebuild }}</td>
-    </tr>
-    <tr{% if genomebuild != "GRCh37" %} style="display: none;"{% endif %}>
+    <tr
+      {% if genomebuild == "GRCh37" %}
+      {% elif genomebuild == "GRCh38" %}
+        style="display: none;"
+      {% else %}
+        class="text-danger"
+      {% endif %}
+    >
       <td>{{ form.thousand_genomes_enabled|as_crispy_field }}</td>
       <td data-toggle="tooltip" title="Phase 3 data (healthy individuals)">1000 Genomes <small class="text-muted">(samples: 1000)</small></td>
       <td>{{ form.thousand_genomes_homozygous|as_crispy_field }}</td>
@@ -35,7 +48,14 @@
       <td>{{ form.thousand_genomes_hemizygous|as_crispy_field }}</td>
       <td>{{ form.thousand_genomes_frequency|as_crispy_field }}</td>
     </tr>
-    <tr{% if genomebuild != "GRCh37" %} style="display: none;"{% endif %}>
+    <tr
+      {% if genomebuild == "GRCh37" %}
+      {% elif genomebuild == "GRCh38" %}
+        style="display: none;"
+      {% else %}
+        class="text-danger"
+      {% endif %}
+    >
       <td>{{ form.exac_enabled|as_crispy_field }}</td>
       <td data-toggle="tooltip" title="Exomes; project attempts to exclude pediatric disease cases">ExAC <small class="text-muted">(samples: 60,706)</small></td>
       <td>{{ form.exac_homozygous|as_crispy_field }}</td>