diff --git a/HISTORY.rst b/HISTORY.rst index 29fce4292..3a46d846f 100644 --- a/HISTORY.rst +++ b/HISTORY.rst @@ -129,6 +129,7 @@ Full Change List - Changing ClinVar link-out to VCV entry instead of coordinates (#693). - Adding unit test for clinvar Vue app (#692). - Moving clinvar Vue app (#711). +- Bugfix that allow clinvar export submission set deletion (#713). ------ v1.2.0 diff --git a/clinvar_export/vueapp/src/api/clinvarExport.js b/clinvar_export/vueapp/src/api/clinvarExport.js index 8ef263f99..e17403916 100644 --- a/clinvar_export/vueapp/src/api/clinvarExport.js +++ b/clinvar_export/vueapp/src/api/clinvarExport.js @@ -49,7 +49,6 @@ async function apiDelete(entity, uuid, appContext) { `Problem with request: ${response.status} ${response.statusText}` ) } - return await response.json() } /** diff --git a/clinvar_export/vueapp/src/store/modules/clinvarExport.js b/clinvar_export/vueapp/src/store/modules/clinvarExport.js index 9e3cc7f71..9c239b24f 100644 --- a/clinvar_export/vueapp/src/store/modules/clinvarExport.js +++ b/clinvar_export/vueapp/src/store/modules/clinvarExport.js @@ -645,9 +645,9 @@ export function extractVariantZygosity(smallVariant, individualUuids, state) { // See whether any individual is annotated as recessive. let anyRecessive = false - let variantAlleleCount = 0 - let variantZygosity = 'not provided' - if (smallVariant) { + let variantAlleleCount = null + let variantZygosity = null + if (smallVariant !== null && smallVariant !== undefined) { let individual = null for (const individualUuid of individualUuids) { const currIndividual = state.individuals[individualUuid] @@ -695,6 +695,12 @@ export function extractVariantZygosity(smallVariant, individualUuids, state) { } } } + if (variantAlleleCount === null) { + variantAlleleCount = 0 + } + if (variantZygosity === null) { + variantZygosity = 'not provided' + } return { variantAlleleCount, variantZygosity } } diff --git a/clinvar_export/vueapp/tests/unit/clinvarExport/api.spec.js b/clinvar_export/vueapp/tests/unit/clinvarExport/api.spec.js index b114bcc4a..4535b38d3 100644 --- a/clinvar_export/vueapp/tests/unit/clinvarExport/api.spec.js +++ b/clinvar_export/vueapp/tests/unit/clinvarExport/api.spec.js @@ -211,7 +211,7 @@ describe('api', () => { `${appContext.baseUrl}/${entityNoUnder}/`, expectedJsonDeleteArgs, ]) - expect(res).toEqual({ fake: 'result' }) + expect(res).toBeUndefined() }) test('getUserAnnotations', async () => {