From e2b8dfc7f3c1bd334c07db64d1d0f30fbb256727 Mon Sep 17 00:00:00 2001 From: steven varga Date: Fri, 8 May 2026 03:55:48 +0000 Subject: [PATCH] [#82]:amelia: wire H5CPP_BUILD_TESTS into CI; remove duplicate option - Add -DH5CPP_BUILD_TESTS=ON to the CI configure step so the Test stage actually builds and runs tests (previously ctest found nothing to run) - Remove duplicate option(H5CPP_BUILD_TESTS ...) declaration that appeared twice in CMakeLists.txt Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/ci.yml | 2 +- CMakeLists.txt | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 65523e9ffa..7861e99e7b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -116,7 +116,7 @@ jobs: - name: Configure if: env.SKIP_COMPILE == 'false' - run: cmake -B build -DCMAKE_CXX_COMPILER=$CXX -DCMAKE_CXX_STANDARD=23 -DCMAKE_BUILD_TYPE=Release + run: cmake -B build -DCMAKE_CXX_COMPILER=$CXX -DCMAKE_CXX_STANDARD=23 -DCMAKE_BUILD_TYPE=Release -DH5CPP_BUILD_TESTS=ON - name: Build if: env.SKIP_COMPILE == 'false' diff --git a/CMakeLists.txt b/CMakeLists.txt index 4d2dd13bf9..4e15423f0a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -71,8 +71,6 @@ if(MPI_FOUND AND HDF5_IS_PARALLEL) message(STATUS "MPI and PHDF5 found: Parallel H5CPP enabled") endif() -option(H5CPP_BUILD_TESTS "Build tests" OFF) - # Header-only target add_library(h5cpp INTERFACE) add_library(h5cpp::h5cpp ALIAS h5cpp)