Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BearyChat #51

Merged
merged 2 commits into from Sep 20, 2016
Merged

Add BearyChat #51

merged 2 commits into from Sep 20, 2016

Conversation

bcho
Copy link
Contributor

@bcho bcho commented Sep 20, 2016

Description

This pull request implements support for BearyChat notification. It requires NOTI_BC_INCOMING_URI envvar.

Resolves

Add a new notification.

@bcho
Copy link
Contributor Author

bcho commented Sep 20, 2016

1474332589

Notification looks like this.

@variadico
Copy link
Owner

Sweet.

Do you have any wisdom about BearyChat that can be recorded here: https://github.com/variadico/noti/blob/master/docs/noti.md?

@bcho
Copy link
Contributor Author

bcho commented Sep 20, 2016

@variadico patch updated!

@variadico
Copy link
Owner

Nice! This is really great!

There's one teeny problem though. Could you reopen this against dev instead of master? 🙏

@bcho bcho changed the base branch from master to dev September 20, 2016 04:40
@bcho
Copy link
Contributor Author

bcho commented Sep 20, 2016

ha, that's on me! Merge base changed!

@variadico variadico merged commit 7e24bf3 into variadico:dev Sep 20, 2016
@variadico
Copy link
Owner

Awesome! Thank you very much! I'll cut a new release in the coming days. 🎉

@bcho
Copy link
Contributor Author

bcho commented Sep 20, 2016

cool!

On Tue, Sep 20, 2016, 1:07 PM Jaime Piña notifications@github.com wrote:

Awesome! Thank you very much! I'll cut a new release in the coming days.
🎉


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#51 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB4jTj83H6kMYu7u7L0T3J45oDh5517nks5qr2n_gaJpZM4KBHVi
.

@variadico variadico added this to the v2.4 milestone Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants