Skip to content

Commit

Permalink
MLK-25674 mmc: sdhci-esdhc-imx: remove command queue feature support
Browse files Browse the repository at this point in the history
We randomly meet command queue related issue on different i.MX SoC with
different eMMC chip. It's hard to reproduce this issue, and we still
can't find the root cause. Accroding to te following performance test,
command queue only get about 5% improvement for sequential read/write,
4%~13% improvement for random read/write. To make system more stable,
here we remove the command queue feature support for all i.MX platform.

use command:
iozone -a -i 0 -i 1 -i 2 -s 2048m -f /home/root/mnt/iozone.test -b /home/root/mnt/iozone_emmc_result.xls -R

test on imx8mm-evk board, Sandisk V5.1 eMMC.

without command queue, get the performance(kBytes/sec):
                                                     random    random
kB  	 reclen    write  rewrite    read    reread    read     write
2097152       4   164683   164807   244399   244171    35079    42381
2097152       8   155790   157385   243465   253506    63294    39578
2097152      16   163053   146252   256447   240317   112037    61052
2097152      32   157465   156050   275889   237867   162464    95467
2097152      64   162197   152512   250558   275592   209406   156292
2097152     128   152056   152205   248962   273060   239077   131292
2097152     256   162449   145993   269115   297437   272436   168179
2097152     512   158773   146120   303000   295046   287286   149343

with command queue, get the performance(kBytes/sec):
                                                     random    random
kB       reclen    write  rewrite    read    reread    read     write
2097152       4   174290   173138   288071   296669    52068    77606
2097152       8   168808   171693   276190   298641    86334   123548
2097152      16   170089   172836   267751   278383    70115   159208
2097152      32   170807   171701   294054   303768   187803   173745
2097152      64   174748   172946   302277   307711   217842   171600
2097152     128   174651   172371   268792   297702   285427   171106
2097152     256   173962   171877   279373   303757   309706   170819
2097152     512   171948   170671   308289   313493   304373   169648

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Acked-by: Sherry Sun <sherry.sun@nxp.com>
  • Loading branch information
Haibo Chen authored and alifermoraes committed Feb 24, 2022
1 parent 3d6203e commit c19da14
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/mmc/host/sdhci-esdhc-imx.c
Expand Up @@ -231,7 +231,6 @@ static struct esdhc_soc_data usdhc_imx8qxp_data = {
.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
| ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
| ESDHC_FLAG_CQHCI
| ESDHC_FLAG_STATE_LOST_IN_LPMODE
| ESDHC_FLAG_CLK_RATE_LOST_IN_PM_RUNTIME,
};
Expand All @@ -240,7 +239,7 @@ static struct esdhc_soc_data usdhc_imx8mm_data = {
.flags = ESDHC_FLAG_USDHC | ESDHC_FLAG_STD_TUNING
| ESDHC_FLAG_HAVE_CAP1 | ESDHC_FLAG_HS200
| ESDHC_FLAG_HS400 | ESDHC_FLAG_HS400_ES
| ESDHC_FLAG_CQHCI | ESDHC_FLAG_BUSFREQ
| ESDHC_FLAG_BUSFREQ
| ESDHC_FLAG_STATE_LOST_IN_LPMODE,
};

Expand Down

0 comments on commit c19da14

Please sign in to comment.