Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Now checking for suggestions file validity #47
Finally got the tests to work. I have used a work around over the get_unique_filename() function in testcases.c. The tests used to fail because some filenames returned by get_unique_filename() did not exist, and I could not understand why there should be an infinite loop in the function (now commented out). The workaround is to create a new file by the generated name.
Also, the ./runtests still show 72%: Checks: 50, Failures: 0, Errors: 14
However, cloning your repo and running the tests produced the same results. So I hope nothing's seriously wrong here.
Got here from your blog. I noticed that you have sent a pull request for your
Then sync your fork with my changes, Follow the instructions at https://help.github.com/articles/syncing-a-fork. This will update your fork with the latest changes went into
Now, create a new branch for your changes.
Apply your changes which you have kept in the text file back to the source files. Don't apply the change you did for infinite loop because that code is removed. It no longer does a infinite loop. Commit the changes and send a PR from the branch.
This is the proper way to develop features and submit PR. You can submit as many commits into the branch and the PR will get updated automatically. You can also amend to one commit and use
This will update the PR with latest changes but keeping only one commit. I'd prefer this way because it keeps the commit history clean.