Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cookie parsing #49

Merged
merged 1 commit into from Nov 29, 2016

Conversation

Projects
None yet
2 participants
@gnosek
Copy link
Contributor

gnosek commented Nov 28, 2016

sep != '\0' is always true (see if (sep == NULL) above).

If *sep == '\0', the parser will skip over the NUL terminator
and keep parsing other headers and the request body looking
for cookies.

Fix cookie parsing
sep != '\0' is always true (see if (sep == NULL) above).

If *sep == '\0', the parser will skip over the NUL terminator
and keep parsing other headers and the request body looking
for cookies.

@gnosek gnosek force-pushed the gnosek:cookie-parsing branch from 59eaff4 to 3d6bbfb Nov 28, 2016

@lkarsten lkarsten merged commit d6b2a99 into varnish:master Nov 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lkarsten

This comment has been minimized.

Copy link
Contributor

lkarsten commented Nov 29, 2016

Thanks!

@gnosek

This comment has been minimized.

Copy link
Contributor Author

gnosek commented Nov 29, 2016

Thanks for merging :) do you plan a release soon? I'm using 0.9.1 now and I don't know whether I should switch to git master or wait for a release

@lkarsten

This comment has been minimized.

Copy link
Contributor

lkarsten commented Nov 30, 2016

@gnosek I recommend you use git master for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.