New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic accessing beresp.backend.ip in vcl_backend_error{} #1865

Closed
bsdphk opened this Issue Mar 4, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@bsdphk
Contributor

bsdphk commented Mar 4, 2016

Old ticket imported from Trac
See archived copy here: https://varnish-cache.org/trac/ticket/1865

@fgsch fgsch self-assigned this Mar 7, 2016

bsdphk added a commit that referenced this issue May 4, 2016

@bsdphk

This comment has been minimized.

Show comment
Hide comment
@bsdphk

bsdphk May 9, 2016

Contributor

This is same issue as #1933 where we will track this issue going forward.

Contributor

bsdphk commented May 9, 2016

This is same issue as #1933 where we will track this issue going forward.

@bsdphk bsdphk closed this May 9, 2016

@fgsch fgsch reopened this May 9, 2016

@fgsch

This comment has been minimized.

Show comment
Hide comment
@fgsch

fgsch May 9, 2016

Member

This is not related to #1933. Please see testcase below:

varnishtest "Accessing beresp.backend.ip does not cause a panic"

varnish v1 -vcl {
        backend default {
                .host = "${bad_ip}";
        }
        sub vcl_backend_error {
                set beresp.http.foo = beresp.backend.ip;
        }
} -start

client c1 {
        txreq
        rxresp
} -run
Member

fgsch commented May 9, 2016

This is not related to #1933. Please see testcase below:

varnishtest "Accessing beresp.backend.ip does not cause a panic"

varnish v1 -vcl {
        backend default {
                .host = "${bad_ip}";
        }
        sub vcl_backend_error {
                set beresp.http.foo = beresp.backend.ip;
        }
} -start

client c1 {
        txreq
        rxresp
} -run

lkarsten pushed a commit that referenced this issue Jun 14, 2016

@bsdphk bsdphk closed this in 7347e93 Feb 2, 2017

hermunn added a commit that referenced this issue Feb 8, 2017

beresp.backend.ip is only available while the connection is open,
which means not in vcl_backend_error{}

Fixes: #1865

Conflicts:
	lib/libvcc/generate.py
@hermunn

This comment has been minimized.

Show comment
Hide comment
@hermunn

hermunn Feb 8, 2017

Contributor

Backport review: Backported as 0c4c164.

Contributor

hermunn commented Feb 8, 2017

Backport review: Backported as 0c4c164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment