Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic accessing beresp.backend.ip in vcl_backend_error{} #1865

Closed
bsdphk opened this issue Mar 4, 2016 · 3 comments
Closed

Panic accessing beresp.backend.ip in vcl_backend_error{} #1865

bsdphk opened this issue Mar 4, 2016 · 3 comments
Assignees

Comments

@bsdphk
Copy link
Contributor

@bsdphk bsdphk commented Mar 4, 2016

Old ticket imported from Trac
See archived copy here: https://varnish-cache.org/trac/ticket/1865

@fgsch fgsch self-assigned this Mar 7, 2016
bsdphk added a commit that referenced this issue May 4, 2016
a family of tickets related to it (#1933 #1920 #1898 (?) #1888 and #1865 (?))
@bsdphk
Copy link
Contributor Author

@bsdphk bsdphk commented May 9, 2016

This is same issue as #1933 where we will track this issue going forward.

@bsdphk bsdphk closed this May 9, 2016
@fgsch fgsch reopened this May 9, 2016
@fgsch
Copy link
Member

@fgsch fgsch commented May 9, 2016

This is not related to #1933. Please see testcase below:

varnishtest "Accessing beresp.backend.ip does not cause a panic"

varnish v1 -vcl {
        backend default {
                .host = "${bad_ip}";
        }
        sub vcl_backend_error {
                set beresp.http.foo = beresp.backend.ip;
        }
} -start

client c1 {
        txreq
        rxresp
} -run
lkarsten pushed a commit that referenced this issue Jun 14, 2016
@bsdphk bsdphk closed this in 7347e93 Feb 2, 2017
hermunn added a commit that referenced this issue Feb 8, 2017
which means not in vcl_backend_error{}

Fixes: #1865

Conflicts:
	lib/libvcc/generate.py
@hermunn
Copy link
Member

@hermunn hermunn commented Feb 8, 2017

Backport review: Backported as 0c4c164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.