Panic accessing beresp.backend.ip in vcl_backend_error{} #1865

Closed
bsdphk opened this Issue Mar 4, 2016 · 3 comments

Projects

None yet

4 participants

@bsdphk
Contributor
bsdphk commented Mar 4, 2016

Old ticket imported from Trac
See archived copy here: https://varnish-cache.org/trac/ticket/1865

@fgsch fgsch self-assigned this Mar 7, 2016
@bsdphk bsdphk added a commit that referenced this issue May 4, 2016
@bsdphk bsdphk Add a bunch of protective asserts on vcl->conf, to help flush out
a family of tickets related to it (#1933 #1920 #1898 (?) #1888 and #1865 (?))
71be412
@bsdphk
Contributor
bsdphk commented May 9, 2016

This is same issue as #1933 where we will track this issue going forward.

@bsdphk bsdphk closed this May 9, 2016
@fgsch fgsch reopened this May 9, 2016
@fgsch
Member
fgsch commented May 9, 2016

This is not related to #1933. Please see testcase below:

varnishtest "Accessing beresp.backend.ip does not cause a panic"

varnish v1 -vcl {
        backend default {
                .host = "${bad_ip}";
        }
        sub vcl_backend_error {
                set beresp.http.foo = beresp.backend.ip;
        }
} -start

client c1 {
        txreq
        rxresp
} -run
@lkarsten lkarsten pushed a commit that referenced this issue Jun 14, 2016
@bsdphk bsdphk + Lasse Karstensen Add a bunch of protective asserts on vcl->conf, to help flush out
a family of tickets related to it (#1933 #1920 #1898 (?) #1888 and #1865 (?))
2e624aa
@bsdphk bsdphk added a commit that closed this issue Feb 2, 2017
@bsdphk bsdphk beresp.backend.ip is only available while the connection is open,
which means not in vcl_backend_error{}

Fixes: #1865
7347e93
@bsdphk bsdphk closed this in 7347e93 Feb 2, 2017
@hermunn hermunn added a commit that referenced this issue Feb 8, 2017
@bsdphk @hermunn bsdphk + hermunn beresp.backend.ip is only available while the connection is open,
which means not in vcl_backend_error{}

Fixes: #1865

Conflicts:
	lib/libvcc/generate.py
0c4c164
@hermunn
Contributor
hermunn commented Feb 8, 2017

Backport review: Backported as 0c4c164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment