varnishstat -f field exclusion glob not working for varnish versions >= 4.0

[zippolyte]

Expected Behavior

With varnish-3.0.7 revision f544cd8 this is what I get and what I suppose is the expected behavior.
Without using exclusion glob:

$ varnishstat -1 -f SMA.*
SMA.s0.c_req                 0         0.00 Allocator requests
SMA.s0.c_fail                0         0.00 Allocator failures
SMA.s0.c_bytes               0         0.00 Bytes allocated
SMA.s0.c_freed               0         0.00 Bytes freed
SMA.s0.g_alloc               0          .   Allocations outstanding
SMA.s0.g_bytes               0          .   Bytes outstanding
SMA.s0.g_space       268435456          .   Bytes available
SMA.Transient.c_req            0         0.00 Allocator requests
SMA.Transient.c_fail           0         0.00 Allocator failures
SMA.Transient.c_bytes            0         0.00 Bytes allocated
SMA.Transient.c_freed            0         0.00 Bytes freed
SMA.Transient.g_alloc            0          .   Allocations outstanding
SMA.Transient.g_bytes            0          .   Bytes outstanding
SMA.Transient.g_space            0          .   Bytes available

Using exclusion glob:

$ varnishstat -1 -f SMA.* -f ^SMA.Transient.*
SMA.s0.c_req                 0         0.00 Allocator requests
SMA.s0.c_fail                0         0.00 Allocator failures
SMA.s0.c_bytes               0         0.00 Bytes allocated
SMA.s0.c_freed               0         0.00 Bytes freed
SMA.s0.g_alloc               0          .   Allocations outstanding
SMA.s0.g_bytes               0          .   Bytes outstanding
SMA.s0.g_space       268435456          .   Bytes available

Current Behavior

Starting with version 4.0, the exclusion field doesn't work anymore:

$ varnishstat -1 -f SMA.* -f ^SMA.Transient
SMA.s0.c_req                 0         0.00 Allocator requests
SMA.s0.c_fail                0         0.00 Allocator failures
SMA.s0.c_bytes               0         0.00 Bytes allocated
SMA.s0.c_freed               0         0.00 Bytes freed
SMA.s0.g_alloc               0          .   Allocations outstanding
SMA.s0.g_bytes               0          .   Bytes outstanding
SMA.s0.g_space       268435456          .   Bytes available
SMA.Transient.c_req            0         0.00 Allocator requests
SMA.Transient.c_fail            0         0.00 Allocator failures
SMA.Transient.c_bytes            0         0.00 Bytes allocated
SMA.Transient.c_freed            0         0.00 Bytes freed
SMA.Transient.g_alloc            0          .   Allocations outstanding
SMA.Transient.g_bytes            0          .   Bytes outstanding
SMA.Transient.g_space            0          .   Bytes available

I don't get any output if I use only an exclusion glob:

$ varnishstat -1 -f ^SMA.*
$

Steps to Reproduce (for bugs)

Try using an exclusion glob with the -f option of varnishstat with varnish >= 4.0

Your Environment

• Versions used: varnishstat (varnish-4.0.0 revision 2acedeb) to varnishstat (varnish-5.1.2 revision 6ece695)
• Operating System and version: Ubuntu 14.04

[fgsch]

Thanks for reporting it. I will take a look.

[hermunn]

Backport review: As you can see from the above, this was backported to 4.1 as 8482ced.