Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on return (retry) of a conditional fetch #2700

Closed
daghf opened this issue Jun 5, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@daghf
Copy link
Member

commented Jun 5, 2018

Error: Child (25874) died signal=6 (core dumped)
Error: Child (25874) Panic at: Tue, 05 Jun 2018 11:52:50 GMT
Assert error in vbf_stp_startfetch(), cache/cache_fetch.c line 352:
  Condition((bo->was_304) == 0) not true.
version = varnish-trunk revision 66a618352483e2d04c9a65fefe2e817c98512de1, vrt api = 7.0
ident = Linux,4.9.0-6-amd64,x86_64,-jnone,-sdefault,-sdefault,-hcritbit,epoll
now = 563586.509936 (mono), 1528199569.057224 (real)
Backtrace:
  0x454050: varnishd() [0x454050]
  0x453e2a: varnishd() [0x453e2a]
  0x507431: varnishd(VAS_Fail+0x51) [0x507431]
  0x436c55: varnishd() [0x436c55]
  0x435553: varnishd() [0x435553]
  0x48b9c0: varnishd() [0x48b9c0]
  0x48b243: varnishd() [0x48b243]
  0x48af8b: varnishd() [0x48af8b]
  0x7f2a0df99494: /lib/x86_64-linux-gnu/libpthread.so.0(+0x7494) [0x7f2a0df99494]
  0x7f2a0dcdbacf: /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f) [0x7f2a0dcdbacf]
thread = (cache-worker)
thr.req = (nil) {
},
thr.busyobj = 0x7f2a02886020 {
  ws = 0x7f2a02886060 {
    id = \"bo\",
    {s, f, r, e} = {0x7f2a02887f60, +560, (nil), +57496},
  },
  retries = 1, flags = {do_stream, was_304},
  http_conn = 0x7f2a028880e0 {
    fd = 26 (@0x7f2a0100e084),
    doclose = NULL,
    ws = 0x7f2a02886060 {
      [Already dumped, see above]
    },
    {rxbuf_b, rxbuf_e} = {0x7f2a02888140, 0x7f2a02888166},
    {pipeline_b, pipeline_e} = {(nil), (nil)},
    content_length = 0,
    body_status = none,
    first_byte_timeout = 60.000000,
    between_bytes_timeout = 60.000000,
  },
  vfc = 0x7f2a02887f18 {
    failed = 0,
    req = 0x7f2a02886628,
    resp = 0x7f2a02886aa0,
    wrk = 0x7f2a0f08cde0,
    oc = 0x7f2a01411180,
    obj_flags = 0x0,
  },
  director_req = 0x7f2a0d012540 {
    cli_name = vcl1.s1,
    health = healthy,
    admin_health = probe, changed = 1528199568.725015,
    type = backend {
      ipv4 = 127.0.0.1,
      port = 42869,
      hosthdr = 127.0.0.1,
      n_conn = 1,
    },
  },
  director_resp = director_req,
  http[bereq] = 0x7f2a02886628 {
    ws = 0x7f2a02886060 {
      [Already dumped, see above]
    },
    hdrs {
      \"GET\",
      \"/\",
      \"HTTP/1.1\",
      \"Host: 127.0.0.1\",
      \"X-Forwarded-For: 127.0.0.1\",
      \"Accept-Encoding: gzip\",
      \"If-None-Match: \"foo\"\",
      \"X-Varnish: 1005\",
      \"retries: 1\",
    },
  },
  http[beresp] = 0x7f2a02886aa0 {
    ws = 0x7f2a02886060 {
      [Already dumped, see above]
    },
    hdrs {
      \"HTTP/1.1\",
      \"304\",
      \"OK\",
      \"Content-Length: 0\",
      \"Date: Tue, 05 Jun 2018 11:52:49 GMT\",
    },
  },
  objcore[fetch] = 0x7f2a01411180 {
    refcnt = 2,
    flags = {busy},
    exp_flags = {},
    boc = 0x7f2a01414080 {
      refcnt = 2,
      state = req_done,
      vary = (nil),
      stevedore_priv = (nil),
    },
    exp = {1528199569.057188, 120.000000, 10.000000, 0.000000},
    objhead = 0x7f2a01416080,
    stevedore = (nil),
  },
  objcore[ims] = 0x7f2a014110c0 {
    refcnt = 3,
    flags = {},
    exp_flags = {refd},
    exp = {1528199568.944563, 0.001000, 0.000000, 3600.000000},
    objhead = 0x7f2a01416080,
    stevedore = 0x7f2a0d0c60c0 (malloc s0) {
      Simple = 0x7f2a0102b100,
      Obj = 0x7f2a0102f068 {priv=0x7f2a0102f060, ptr=0x7f2a0102b100, len=224, space=224},
      LEN = 0x0000000000000001,
      VXID = 0x000003ea,
      FLAGS = 0x08,
      GZIPBITS = 0x0...0,
      LASTMODIFIED = 0x41d6c59e64000000,
      VARY = {len=0, ptr=(nil)},
      HEADERS = {len=104, ptr=0x7f2a0102b178},
      Body = 0x7f2a0102f0b8 {priv=0x7f2a0102f0b0, ptr=0x7f2a01030058, len=1, space=1},
    },
  },
  vcl = {
    name = \"vcl1\",
    busy = 2,
    discard = 0,
    state = auto,
    temp = warm,
    conf = {
      srcname = {
        \"<vcl.inline>\",
        \"Builtin\",
      },
    },
  },
  vmods = {
  },
},


Debug: Child cleanup complete

@daghf daghf closed this in 2c5dfd8 Jun 5, 2018

daghf added a commit that referenced this issue Jun 5, 2018

Dridi added a commit to Dridi/varnish-cache that referenced this issue Jun 20, 2018

Clear bo->was_304 on return(retry)
Fixes: varnishcache#2700

Conflicts:
	bin/varnishd/cache/cache_fetch.c

hermunn added a commit to hermunn/varnish-cache that referenced this issue Aug 27, 2018

@hermunn

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2018

Back ported to 4.1 as 49e6b53.

dmatetelki added a commit to dmatetelki/varnish-cache that referenced this issue Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.