You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This bug will trigger whenever a PRIV_TOP is requested only from esi_level > 0 and used by a "sibling" ESI request, that is, another request on the same ESI level or its descendants.
The bug was introduced by someone(tm) here 542bf9b: I removed req = req->top->topreq but continued to use the workspace from req->ws.
The bug is exposed with this change to v00043.vtc
@@ -40,15 +55,23 @@ varnish v1 -cliok "param.set debug +syncvsl" -vcl+backend {
sub vcl_init {
new o = debug.obj();
+ new o2 = debug.obj();
}
sub vcl_recv {
set req.http.x0 = debug.test_priv_top(req.url + req.esi_level);
- o.test_priv_top(req.url + req.esi_level);
+ if (req.url == "/foo1") {
+ o.test_priv_top(req.url + req.esi_level);
+ } else {
+ o2.test_priv_top(req.url + req.esi_level);
+ }
}
sub vcl_miss {
set req.http.x1 = debug.test_priv_top("");
+ if (req.esi_level > 0) {
+ set req.http.o1 = o.test_priv_top("");
+ }
}
sub vcl_backend_response {
proforma bug for fix on the way:
VRT_priv_top()
uses the wrong workspace here:varnish-cache/bin/varnishd/cache/cache_vrt_priv.c
Line 223 in 1952d3c
The correct workspace is the top requests's.
This bug will trigger whenever a PRIV_TOP is requested only from esi_level > 0 and used by a "sibling" ESI request, that is, another request on the same ESI level or its descendants.
The bug was introduced by someone(tm) here 542bf9b: I removed
req = req->top->topreq
but continued to use the workspace fromreq->ws
.The bug is exposed with this change to
v00043.vtc
panic:
The text was updated successfully, but these errors were encountered: