New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vsm_free (never incremented) #2188

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@ehocdet
Contributor

ehocdet commented Jan 16, 2017

a proposal fix for the issue: #2187

@Dridi

This comment has been minimized.

Show comment
Hide comment
@Dridi

Dridi Jan 16, 2017

Member

For some reason beyond me the build fails on travis while this patch was applied on an up to date master, so I wouldn't be bothered by that. I've seen another build of master passing.

LGTM, well spotted!

Member

Dridi commented Jan 16, 2017

For some reason beyond me the build fails on travis while this patch was applied on an up to date master, so I wouldn't be bothered by that. I've seen another build of master passing.

LGTM, well spotted!

@fgsch

This comment has been minimized.

Show comment
Hide comment
@fgsch

fgsch Jan 16, 2017

Member

I'd prefer this is done in VSM_common_free() together where g_used is decremented.

Nevermind this. I re-read the code and this is the correct approach. OK with me.

Member

fgsch commented Jan 16, 2017

I'd prefer this is done in VSM_common_free() together where g_used is decremented.

Nevermind this. I re-read the code and this is the correct approach. OK with me.

@Dridi

This comment has been minimized.

Show comment
Hide comment
@Dridi

Dridi Jan 17, 2017

Member

Catching up with unread commits, I now believe that a29fca7 breaks pull request builds.

Member

Dridi commented Jan 17, 2017

Catching up with unread commits, I now believe that a29fca7 breaks pull request builds.

@fgsch

This comment has been minimized.

Show comment
Hide comment
@fgsch

fgsch Jan 17, 2017

Member

Merged. Thanks for the PR!

Member

fgsch commented Jan 17, 2017

Merged. Thanks for the PR!

@hermunn

This comment has been minimized.

Show comment
Hide comment
@hermunn

hermunn Jan 25, 2017

Contributor

Backport review: Patch b8dec33 backported as 1978ebf.

Contributor

hermunn commented Jan 25, 2017

Backport review: Patch b8dec33 backported as 1978ebf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment