fix vsm_free (never incremented) #2188

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@ehocdet
Contributor
ehocdet commented Jan 16, 2017

a proposal fix for the issue: #2187

@Dridi
Member
Dridi commented Jan 16, 2017

For some reason beyond me the build fails on travis while this patch was applied on an up to date master, so I wouldn't be bothered by that. I've seen another build of master passing.

LGTM, well spotted!

@fgsch
Member
fgsch commented Jan 16, 2017 edited

I'd prefer this is done in VSM_common_free() together where g_used is decremented.

Nevermind this. I re-read the code and this is the correct approach. OK with me.

@Dridi
Member
Dridi commented Jan 17, 2017

Catching up with unread commits, I now believe that a29fca7 breaks pull request builds.

@fgsch
Member
fgsch commented Jan 17, 2017

Merged. Thanks for the PR!

@fgsch fgsch closed this Jan 17, 2017
@hermunn
Contributor
hermunn commented Jan 25, 2017

Backport review: Patch b8dec33 backported as 1978ebf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment