Make sure Age is always less than max-age #2216

Merged
merged 1 commit into from Mar 4, 2017

Conversation

Projects
None yet
5 participants
@rezan
Member

rezan commented Feb 15, 2017

By rounding Age down, we make sure Age < max-age while the object
is fresh. Otherwise, we can prematurely get Age == max-age and Varnish
will calculate that as a 0s TTL and create a pass scenario.

More info can be found in this dev list email:

https://www.varnish-cache.org/lists/pipermail/varnish-dev/2016-December/009079.html

Make sure Age is always less than max-age
By rounding Age down, we make sure Age < max-age while the object
is fresh. Otherwise, we can prematurely get Age == max-age and Varnish
will calculate that as a 0s TTL and create a pass scenario.
@rezan

This comment has been minimized.

Show comment
Hide comment
@rezan

rezan Feb 16, 2017

Member

Not sure why Travis is failing here, that vtc is unrelated and passes before and after on my local.

Member

rezan commented Feb 16, 2017

Not sure why Travis is failing here, that vtc is unrelated and passes before and after on my local.

@gquintard

This comment has been minimized.

Show comment
Hide comment
@gquintard

gquintard Feb 16, 2017

Contributor

I restarted the job, and it seems to pass. It was probably just an issue with acquiring ports.

Contributor

gquintard commented Feb 16, 2017

I restarted the job, and it seems to pass. It was probably just an issue with acquiring ports.

@bsdphk bsdphk added the a=OK'ed label Feb 23, 2017

@bsdphk

This comment has been minimized.

Show comment
Hide comment
@bsdphk

bsdphk Feb 23, 2017

Contributor

OK.

I worry that the test-case may be too timing sensitive, so keep an eye on Vtest until we know.

Contributor

bsdphk commented Feb 23, 2017

OK.

I worry that the test-case may be too timing sensitive, so keep an eye on Vtest until we know.

@rezan rezan merged commit 91ee053 into varnishcache:master Mar 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hermunn

This comment has been minimized.

Show comment
Hide comment
@hermunn

hermunn Apr 6, 2017

Contributor

Backport review: The commit 104af2a has been backported as 14ce480.

Contributor

hermunn commented Apr 6, 2017

Backport review: The commit 104af2a has been backported as 14ce480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment