Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Age is always less than max-age #2216

Merged
merged 1 commit into from Mar 4, 2017

Conversation

@rezan
Copy link
Member

@rezan rezan commented Feb 15, 2017

By rounding Age down, we make sure Age < max-age while the object
is fresh. Otherwise, we can prematurely get Age == max-age and Varnish
will calculate that as a 0s TTL and create a pass scenario.

More info can be found in this dev list email:

https://www.varnish-cache.org/lists/pipermail/varnish-dev/2016-December/009079.html

By rounding Age down, we make sure Age < max-age while the object
is fresh. Otherwise, we can prematurely get Age == max-age and Varnish
will calculate that as a 0s TTL and create a pass scenario.
@rezan
Copy link
Member Author

@rezan rezan commented Feb 16, 2017

Not sure why Travis is failing here, that vtc is unrelated and passes before and after on my local.

@gquintard
Copy link
Contributor

@gquintard gquintard commented Feb 16, 2017

I restarted the job, and it seems to pass. It was probably just an issue with acquiring ports.

@bsdphk bsdphk added the a=OK'ed label Feb 23, 2017
@bsdphk
Copy link
Contributor

@bsdphk bsdphk commented Feb 23, 2017

OK.

I worry that the test-case may be too timing sensitive, so keep an eye on Vtest until we know.

@rezan rezan merged commit 91ee053 into varnishcache:master Mar 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hermunn
Copy link
Member

@hermunn hermunn commented Apr 6, 2017

Backport review: The commit 104af2a has been backported as 14ce480.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.