blockquote.css #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use 2 spaces over tabs, indent correctly - Replace `!<...>.blank?`s with `<...>.present?` - Replace `!<...>.empty?`s with `<...>.any?`
* Clean up code duplication in rails js * More fixes * Even more clean up * Fix bug with displaying client side errors on forms * More tests * Fix indentation issues
* wip(react-i18n): setup linters for react ci, fix lint errors, update flow-typed, mount path for i18n libs absolute import. * feat(i18n): display storybook example of a dynamically changing I18n Component. * feat(i18n): complete the integration of React-i18n to components in Storybook. * refactor(react): make all components contributed adhere to i18n specifications. * fix(webpack): fix react-on-rails plugin not understanding resolve.modules in webpack. * fix(styles): fix up linting rules modification. * style(Dropdown): add explicit case when locale is null or undefined. * style(client): clean up styles for code climate #1 * fix(webpack): add glob module to automatically extract all register points in client, make client resolve js and jsx. * style(codeclimate): adjust javascript mass threshold for duplication. * chore(codeclimate): pass lint and adjust code climate js duplcation mass weights
* Use info add-on in Storybook to show source code * Fix Linter errors * Include client js in Codeclimate check
* Headings created * fix lint error * Update Heading.scss * span removed * fixes lint errors
Fixes issue ifmeorg#847 [Component] Blockquote.
* Add George Karametas(me) to contributors
* Add Avatar component
* Splitting up Storybook stories into separate files * Disabling TODO checks for CodeClimate * Removing published build * Fixing lint errors * Fixing comment * Fixing karma test; fixing peer dependency requirement * Adding expects to capybara tests * Adding helper for tests to check page transitions * Fixing merge conflicting dangling line * Updating scripts, fixing component names * Fixing defaultProps for Dropdown * Fixing missing photo and webpack config * Trigger codeclimate * Adding missing EOL * Fixing storybook webpack config * Updating loofah gem for circleci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue ifmeorg#847 [Component] Blockquote.