Skip to content

Vasia Kalavri
vasia

  • KTH
  • Stockholm, Sweden
  • Joined on
vasia commented on pull request apache/flink#1567
@vasia

Hey @ChengXiangLi, I merged your changes together with #1600. You can close this.

vasia closed pull request apache/flink#1600
@vasia
[FLINK-3226] Translate logical aggregations to physical
vasia commented on pull request apache/flink#1600
@vasia

It's all green :D Merging.

@vasia
  • @vasia e45f29e
    [FLINK-3226] implement getUniqueName method in TranslationContext
vasia commented on pull request apache/flink#1600
@vasia

@fhueske I fixed the aggregation hashCode and enables the ignored tests. Let me know if it's OK now!

@vasia
  • @vasia 0ece057
    [FLINK-3226] implement hashCode() in Aggregation
@vasia
  • @vasia f97dc65
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
@vasia
  • @vasia bea0f85
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
@vasia
  • @vasia dae6737
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
@vasia
  • @vasia 8797347
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
vasia commented on pull request apache/flink#1600
@vasia

I've rebased this one on top of tableOnCalcite which includes #1595. Regarding the average aggregate, I went for @tillrohrmann's suggestion of addi…

vasia commented on pull request apache/flink#1595
@vasia

Hey @twalthr, I merged this yesterday but the PR didn't automatically close. Could you please close it manually? Thanks!

@vasia
  • @vasia c2a100b
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
  • @ChengXiangLi 87b8135
    [Flink-3226] Translate logical plan FlinkRels into physical plan Data…
  • 1 more commit »
@vasia
  • @vasia 4b6a6ab
    [FLINK-3226] fix exception types for failing tests; fix checkstyle er…
vasia created branch timos_branch at vasia/flink
vasia commented on pull request apache/flink#1595
@vasia

Thanks for the quick update @twalthr! Some tests are failing because the wrong type of exception is expected. I'll fix those and then merge this.

vasia commented on pull request apache/flink#1600
@vasia

I know. However, aggregating on a Double and then calling toInt before returning the result led to rounding errors. e.g. there was a test where the…

vasia commented on pull request apache/flink#1600
@vasia

Thanks for the feedback @tillrohrmann, @twalthr! I've moved the classes to org.apache.flink.api.table.runtime and tried to shorten the aggregates c…

@vasia
  • @vasia 63e38d4
    [FLINK-3226] Move aggregation functions to org.apache.flink.table.run…
vasia commented on pull request apache/flink#1600
@vasia

I like @tillrohrmann's suggestion. Any reason why not use Scala's Numeric though?

vasia commented on pull request apache/flink#1600
@vasia

Sounds reasonable. Together with the expression functions or separately, e.g. in org.apache.flink.table.runtime.functions?

vasia commented on pull request apache/flink#1600
@vasia

Yes, we decided to disable AggregateReduceFunctionsRule temporarily, thus the note on top. I could remove it completely if you think it'd be better.

vasia commented on pull request apache/flink#1600
@vasia

I missed to correct this, thnx!

vasia opened pull request apache/flink#1600
@vasia
[FLINK-3226] Translate logical aggregations to physical
2 commits with 1,060 additions and 56 deletions
@vasia
  • @vasia cf41b74
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
@vasia
  • @vasia 86f24d7
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
@vasia
  • @vasia 65ecbe8
    [FLINK-3226] compute average as sum and count for byte, short and int…
@vasia
  • @vasia 8748d41
    [FLINK-3226] implement GroupReduce translation; enable tests for supp…
@vasia
  • @vasia 2a5d832
    [FLINK-3226] copy grouping fields and aggregates from last row to output
Something went wrong with that request. Please try again.