New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter with "prefix in IP" expression fails when importing MRT data that includes the type mrt::bgp4mp::state_change #201

Open
josephnoir opened this Issue Jun 7, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@josephnoir
Contributor

josephnoir commented Jun 7, 2018

This error occurs when importing data MRT updates from RIPE RIS. Updates downloaded from Routeviews seem not include the problematic event type mrt::bgp4mp::state_change. Here's the import statement that was problematic for me:

gunzip -c updates.20180530.0000.gz | vast import mrt "114.215.46.175 in prefix"

And here's my debug output from couts in expression.cpp and expression_visitors.cpp which lead me to suspect a problem with the state_change:

tailor called
 type: mrt::bgp4mp::update::announcement
 expression: prefix ni 114.215.46.175
type_resolver created with: mrt::bgp4mp::update::announcement
resolving predicate: prefix ni 114.215.46.175
 operator is: ni
resolving key_extractor 'prefix' with data: 114.215.46.175
Returning std::move(dis[0])
 resolved to: mrt::bgp4mp::update::announcement@2 ni 114.215.46.175
parsing predicate: mrt::bgp4mp::update::announcement@2 ni 114.215.46.175
 pruned to: mrt::bgp4mp::update::announcement@2 ni 114.215.46.175
tailor done
tailor called
 type: mrt::bgp4mp::update::withdrawn
 expression: prefix ni 114.215.46.175
type_resolver created with: mrt::bgp4mp::update::withdrawn
resolving predicate: prefix ni 114.215.46.175
 operator is: ni
resolving key_extractor 'prefix' with data: 114.215.46.175
Returning std::move(dis[0])
 resolved to: mrt::bgp4mp::update::withdrawn@2 ni 114.215.46.175
parsing predicate: mrt::bgp4mp::update::withdrawn@2 ni 114.215.46.175
 pruned to: mrt::bgp4mp::update::withdrawn@2 ni 114.215.46.175
tailor done
tailor called
 type: mrt::bgp4mp::state_change
 expression: prefix ni 114.215.46.175
type_resolver created with: mrt::bgp4mp::state_change
resolving predicate: prefix ni 114.215.46.175
 operator is: ni
resolving key_extractor 'prefix' with data: 114.215.46.175
Returning empty expression
 resolved to: nil
parsing none
@mavam

This comment has been minimized.

Show comment
Hide comment
@mavam

mavam Jun 7, 2018

Member

It'd be great to reproduce this with your input data. Is it shareable?

Member

mavam commented Jun 7, 2018

It'd be great to reproduce this with your input data. Is it shareable?

@mavam mavam added the bug label Jun 7, 2018

@josephnoir

This comment has been minimized.

Show comment
Hide comment
@josephnoir

josephnoir Jun 8, 2018

Contributor

Sure, its public data. Here are the directory and the file I used above. We'll use the routviews data for now, so there is not urgency to fix this.

Contributor

josephnoir commented Jun 8, 2018

Sure, its public data. Here are the directory and the file I used above. We'll use the routviews data for now, so there is not urgency to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment