Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starts a FrameTicker when imported #171

Closed
grassick opened this issue Aug 16, 2023 · 2 comments
Closed

Starts a FrameTicker when imported #171

grassick opened this issue Aug 16, 2023 · 2 comments

Comments

@grassick
Copy link

When importing the package globe.gl, it immediately starts a timer that can be seen in Chrome debugger, even without instatiating a globe. This is because of:

// Expose config from ThreeGlobe
var bindGlobe = linkKapsule('globe', ThreeGlobe);

To Reproduce

Steps to reproduce the behavior:

  1. Import globe.gl into a esbuild project
  2. Open Chrome debugger and run record in performance
  3. See calls to frame-ticker

Expected behavior

It should not be running a ticker of any kind when the globe is not instantiated

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Chrome
  • Version: 115
@vasturiano
Copy link
Owner

Thanks for your report @grassick! I've just improved the cleanup mechanism, so you should no longer see any rafs from this module prior to instantiation. Please update to the latest version of the module.

@grassick
Copy link
Author

I just installed it and confirmed that it works. Thank you for your quick fix and fabulous library! You can see the visualization I made with it at https://solstice.world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants