From c0b76c562f6f0195983acb643eb6a40e60d1d314 Mon Sep 17 00:00:00 2001 From: Florent BEAUCHAMP Date: Mon, 30 Oct 2023 15:20:30 +0100 Subject: [PATCH] fix(@xen-orchestra/backups): fix METHOD_NOT_ALLOWED when doing full backup introduced by #7086 --- @xen-orchestra/backups/_runners/_vmRunners/FullXapi.mjs | 3 ++- CHANGELOG.unreleased.md | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/@xen-orchestra/backups/_runners/_vmRunners/FullXapi.mjs b/@xen-orchestra/backups/_runners/_vmRunners/FullXapi.mjs index 86ca19d91a3..10d22d6fe45 100644 --- a/@xen-orchestra/backups/_runners/_vmRunners/FullXapi.mjs +++ b/@xen-orchestra/backups/_runners/_vmRunners/FullXapi.mjs @@ -39,7 +39,8 @@ export const FullXapi = class FullXapiVmBackupRunner extends AbstractXapi { const vdis = await exportedVm.$getDisks() let maxStreamLength = 1024 * 1024 // Ovf file and tar headers are a few KB, let's stay safe for (const vdiRef of vdis) { - const vdi = await this._xapi.getRecord(vdiRef) + const vdi = await this._xapi.getRecord('VDI', vdiRef) + // at most the xva will take the physical usage of the disk // the resulting stream can be smaller due to the smaller block size for xva than vhd, and compression of xcp-ng maxStreamLength += vdi.physical_utilisation diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index 4cfc851dcff..86ea7ecf25c 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -12,6 +12,7 @@ > Users must be able to say: “I had this issue, happy to know it's fixed” - [Netbox] Fix "The selected cluster is not assigned to this site" error [Forum#7887](https://xcp-ng.org/forum/topic/7887) (PR [#7124](https://github.com/vatesfr/xen-orchestra/pull/7124)) +- [Backups] Fix "METHOD_UNKNOWN" during full backup [Forum#7894](https://xcp-ng.org/forum/topic/7894)(PR [#7139](https://github.com/vatesfr/xen-orchestra/pull/7139)) ### Packages to release @@ -29,6 +30,7 @@ +- @xen-orchestra/backups patch - xo-server-netbox patch