Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/new-vm): only create the cloud config drive when its option is enabled #3162

Merged
merged 2 commits into from Jul 9, 2018
Merged

fix(xo-web/new-vm): only create the cloud config drive when its option is enabled #3162

merged 2 commits into from Jul 9, 2018

Conversation

badrAZ
Copy link
Contributor

@badrAZ badrAZ commented Jul 9, 2018 •
edited

This bug has been introduced by the PR: #3054

Fixes #3161

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

@badrAZ badrAZ self-assigned this Jul 9, 2018
@badrAZ badrAZ requested review from julien-f and removed request for julien-f July 9, 2018 08:45
@julien-f julien-f merged commit 16f8029 into master Jul 9, 2018
@julien-f julien-f deleted the fixCloudConfig branch July 9, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f Awaiting requested review from julien-f

Assignees

@badrAZ badrAZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudConfigDrive is always created
2 participants
@badrAZ @julien-f