Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/tasks): remove empty message and let SortedTable handle it #3305

Merged
merged 2 commits into from Aug 13, 2018
Merged

feat(xo-web/tasks): remove empty message and let SortedTable handle it #3305

merged 2 commits into from Aug 13, 2018

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Aug 13, 2018

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

Screenshots

capture_2018-08-13_17 02 12

@pdonias pdonias merged commit 11bd75d into master Aug 13, 2018
@pdonias pdonias deleted the pierre-remove-tasks-empty-message branch August 13, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI Rajaa-BARHTAOUI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdonias @Rajaa-BARHTAOUI