Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patching rework #4077

Merged
merged 46 commits into from Mar 28, 2019
Merged

Patching rework #4077

merged 46 commits into from Mar 28, 2019

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Mar 26, 2019 •
edited

See #2565
See #3655
Fixes #2188
Fixes #3777
Fixes #3783
Fixes #3934
Fixes support#1228
Fixes support#1338
Fixes support#1362

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer
  4. if necessary, update your PR, and re- add a reviewer

@pdonias pdonias changed the title Rework patching Patching rework Mar 27, 2019
@pdonias pdonias requested a review from badrAZ March 27, 2019 15:41
badrAZ
badrAZ reviewed Mar 27, 2019
View reviewed changes
packages/xo-server/src/api/pool.js Outdated
target: { type: 'string' },
}

mergeInto.resolve = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPatchesDifference

@pdonias pdonias requested a review from badrAZ March 27, 2019 16:15
pdonias and others added 25 commits March 28, 2019 16:59
@pdonias
pool_update object type
16d1e29
@pdonias
Ignore packs
d84fa9d
@pdonias
Fix XCP-ng patch fetching issue
37a85b2
@pdonias
Upload patch on any SR
c961309
@pdonias
Always use host_patch and pool_patch objects
bec8366
@pdonias
patch type
ecd68f0
@pdonias
Fix mergeInto diff computing
a07cfbf
@pdonias
Fix
dd185ed
@pdonias
Expose getPatchesDifference
1af318f
@pdonias
fix
1e210a9
@pdonias
Install missing patches on target as well before joining
89fa7dd
@Rajaa-BARHTAOUI @pdonias
UI
5fd4f36
@pdonias
Missing file
c933f0e
@Rajaa-BARHTAOUI @pdonias
join host: warning when missing patches (#4069)
5e82488
@pdonias
Fix vdi.$ref
90b7644
@pdonias
Listing: handle paid patch on free host
2e5aab4
@Rajaa-BARHTAOUI @pdonias
dashbord/overview: remove install patches (#4080)
a069106
@Rajaa-BARHTAOUI @pdonias
Rework patching: fix UI (#4082)
565a732
@pdonias
return → await in the installation loop
db2f159
@pdonias
Fix xo-server-usage-report call
9fe3f84
@pdonias
CHANGELOG
9268884
@pdonias
mergeInto → getPatchesDifference
2efd568
@pdonias
Fix getPatchesDifference
9fbc3ae
@pdonias
Detailed changelog
dacb813
@pdonias
Fix XCP install on single host
05ee1f8
@pdonias pdonias merged commit cde9a02 into master Mar 28, 2019
@pdonias pdonias deleted the pierre-rework-patching branch March 28, 2019 16:05
julien-f pushed a commit that referenced this pull request Mar 28, 2019
@pdonias @julien-f
fix(xo-server,xo-web,xo-server-usage-report): patches (#4077)
9ee240f 
See #2565
See #3655
Fixes #2188
Fixes #3777
Fixes #3783
Fixes #3934
Fixes support#1228
Fixes support#1338
Fixes support#1362

- mergeInto: fix auto-patching on XS < 7.2
- mergeInto: homogenize both the host and pool's patches
- correctly install specific patches
- XCP-ng: fix "xcp-ng-updater not installed" bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI Rajaa-BARHTAOUI approved these changes

@badrAZ badrAZ badrAZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@pdonias @Rajaa-BARHTAOUI @badrAZ