Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/createBondedNetwork): remove vlan param #4429

Merged
merged 2 commits into from Aug 22, 2019

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Aug 19, 2019

Fixes #4425
Introduced by 7a2a88b

Check list

Check items when done or if not relevant

  • PR reference the relevant issue (e.g. Fixes #007)
  • if UI changes, a screenshot has been added to the PR
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • documentation updated
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

@pdonias pdonias requested review from julien-f and removed request for Rajaa-BARHTAOUI August 22, 2019 07:17
@julien-f julien-f merged commit a86abde into master Aug 22, 2019
@julien-f julien-f deleted the pierre-fix-new-bonded-network branch September 20, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateBridge should not contain VLAN property
2 participants