Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Import/VMDK] Fix broken import of VMDK disks #5087

Merged
merged 3 commits into from Jun 15, 2020
Merged

Conversation

nraynaud
Copy link
Member

@nraynaud nraynaud commented Jun 15, 2020

Discovered while testing something else.

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@nraynaud nraynaud changed the title WiP: [Import/VMDK] Fix broken import of VMDK disks [Import/VMDK] Fix broken import of VMDK disks Jun 15, 2020
@nraynaud nraynaud requested a review from julien-f June 15, 2020 14:15
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@nraynaud nraynaud requested a review from julien-f June 15, 2020 14:59
@julien-f julien-f merged commit 3578d16 into master Jun 15, 2020
@julien-f julien-f deleted the nr-fix-vmdk-disk-import branch June 15, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants