Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server,xo-web/host/advanced): add IOMMU state #5294

Merged
merged 5 commits into from Oct 1, 2020
Merged

feat(xo-server,xo-web/host/advanced): add IOMMU state #5294

merged 5 commits into from Oct 1, 2020

Conversation

MathieuRA
Copy link
Member

Fixes #4936

Screenshot

#4936

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@pdonias pdonias self-requested a review September 30, 2020 09:32
@@ -906,6 +906,7 @@ const messages = {
hostLicenseSocket: 'Socket',
hostLicenseExpiry: 'Expiry',
hostRemoteSyslog: 'Remote syslog',
hostIommu: 'Iommu',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iommu is an acronym for "Input–output memory management unit". As is, it should be in caps, IOMMU.

For people curious about it, you can read https://en.wikipedia.org/wiki/Input%E2%80%93output_memory_management_unit

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-server/src/xapi-object-to-xo.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-server/src/xapi-object-to-xo.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias October 1, 2020 08:04
@pdonias pdonias changed the title feat(xo-web,xo-server/host/chipset_info): add iommu state on advanced tab feat(xo-server,xo-web/host/advanced): add IOMMU state Oct 1, 2020
@pdonias pdonias merged commit 24a69bc into vatesfr:master Oct 1, 2020
@olivierlambert
Copy link
Member

First PR merged, congrats 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Displays more advanced host info on virt capabilities
3 participants