Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server): secondary backups #6807

Closed
wants to merge 3 commits into from
Closed

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 2, 2023

Description

  • Full and Delta backup job are renamed Full and incremental backup job
  • inside a incremental backup job, Full and delta transfer are renamed are renamed base and delta
  • the "baseVm" used for computing the snapshot of delta is renamed comparisonBasisVm

splitted :

  • _VmBackup in AbstractVmBackup, _IncrementalVmBackup, _FullVmBackup
  • Backup.js AbstractBackup, VmsBackup, MetadataBackup and moved to a _backupJob Folder

extracted the different way to read a vm to _vmReader

the writer contains backup specific code => move them to the vmBackup folder

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the refactor_backup branch 11 times, most recently from 066e23c to d38316f Compare May 9, 2023 07:22
…r secondary backup

* full and delta backup jobs are renamed to full and incremental
* inside an incremental job, the full and delta transfers are renamed to base and delta transver
* the baseVm used for computing the snapshot is renamed to comparisasonBasisVm
* split a lot of files to extract reusable methods
* use a factory to instantiates BackubJob, the Backup* classes are now private by convention
* the VmBackups class are instatiated by a XapiBackupJob => move them to the _backup folder
* the writers need a VmBackup in their constructor: move them to the vmBackup folder
@fbeauchamp
Copy link
Collaborator Author

superseed by #6854

@fbeauchamp fbeauchamp closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant