New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimap implementations don't have a method to create from java.util.Map #1767

Closed
asarkar opened this Issue Dec 19, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@asarkar

asarkar commented Dec 19, 2016

While HashMap has an ofAll method, HashMultimap.Builder doesn't. Also, the former has static creational of methods while the later doesn't and creating a builder first is required. I think I understand why though, the value for a multimap can be a general sequence or a set, but I'm not sure the inconsistency it introduces is worth the benefit, because whoever needs it can convert a Seq to a Set by various means.

@danieldietrich

This comment has been minimized.

Member

danieldietrich commented Dec 27, 2016

Yes, I also think the creational API of Multimap still can get hardened. I will take your suggestions into account when re-visiting the Multimap API before the 2.1.0-beta release.

@danieldietrich

This comment has been minimized.

Member

danieldietrich commented Feb 10, 2017

@asarkar I think @ruslansennov added all missing methods. Please give us a sign if still s.th. is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment