Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare migration guide from v2 to v3 #808

Closed
radekmie opened this issue Oct 9, 2020 · 1 comment
Closed

Prepare migration guide from v2 to v3 #808

radekmie opened this issue Oct 9, 2020 · 1 comment
Assignees
Labels
Type: Feature New features and feature requests
Milestone

Comments

@radekmie
Copy link
Member

radekmie commented Oct 9, 2020

As v3 release is getting closer every day, before an actual launch we'll need a written migration guide. The best start would be to collect all changelog entries.

@radekmie radekmie added the Type: Feature New features and feature requests label Oct 9, 2020
@radekmie radekmie added this to the v3.0 milestone Oct 9, 2020
@radekmie radekmie self-assigned this Oct 9, 2020
@radekmie radekmie added this to Needs triage in Open Source (migrated) via automation Oct 9, 2020
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Oct 9, 2020
@radekmie
Copy link
Member Author

radekmie commented Nov 30, 2020

(this comment will be updated)

NOTE: This guide is designed to help you through the migration. If you went through it and encountered any problems - do let us know. For more information on why certain changes were made, see the CHANGELOG.md.
NOTE: When migrating to v3, use the newest version. Gradual updates will take more time and won't ease this process.

  1. Validation flow changes
    • Bridge validators have to return errors instead of throwing them.
       // GraphQL Schema
       function validator(model) {
         if (errors.length) {
      -    throw { details: validator.errors };
      +    return { details: validator.errors };
         }
       }
      
       // JSON Schema
       function createValidator(schema) {
         const validator = ajv.compile(schema);
         return (model) => {
           validator(model);
           if (validator.errors && validator.errors.length) {
      -      throw { details: validator.errors };
      +      return { details: validator.errors };
           }
         };
       }
    • Removed onSubmitSuccess and onSubmitFailure. Perform all needed operations directly in the onSubmit:
      -onSubmit={onSubmit}
      -onSubmitSuccess={onSubmitSuccess}
      -onSubmitFailure={onSubmitFailure}
      +onSubmit={model => {
      +  const result = onSubmit(model);
      +  result.then(onSubmitSuccess, onSubmitFailure);
      +  return result;
      +}}`
    • onValidate is no longer using callbacks. The error (or the lack of it) has to be returned either synchronously or asynchronously (i.e. wrapped in a promise).
      -onValidate={(error, done) => done(error)}
      +onValidate={async error => error}
  2. Legacy React Context API -> [New] React Context API
    • If you were not using context, contextTypes, childContextTypes, or getChildContext* methods directly, there's nothing to do.
    • For direct context access, use useForm hook (functional components), contextType static property (class components), or <context.Consumer /> (both).
      • The React context object, context, is exported from the uniforms package.
  3. Breaking API changes
    • Context data shape has changed: changed, changedMap, submitting, and validating were lifted from the state property to the root.
    • Removed AutoForm.state.modelSync. Use AutoForm.state.model instead.
    • Removed BaseField. Use connectField or useField instead.
    • Removed BaseForm.getChangedKeys. Use changedKeys directly.
    • Removed BaseForm.state.bridge. Use BaseForm.props.schema instead.
    • Removed Bridge.check. Without createSchemaBridge it's no longer needed.
    • Removed baseField from connectField options. There's no one solution here and it may require additional changes, depending on the usage.
    • Removed createSchemaBridge. Now all *Bridge instances have to be created manually.
    • Removed ensureValue from connectField options. That means undefined will no longer be automatically passed to the field as ''. Use value ?? '' instead. This option was enabled by default, therefore it will impact all your custom fields.
    • Removed includeParent from connectField options. Use useField as many times as needed instead.
      const parentName = joinName(joinName(null, props.name).slice(0, -1));
      const parentField = useField(parentName, {}, { absoluteName: true })[0];
    • Removed injectName. In most cases, it can be safely omitted.
    • Removed mapProps from connectField options. Map props directly in the component.
    • Removed nothing. Use null instead.
    • Removed all propTypes in favor of TypeScript types.
    • Renamed or removed deprecated lifecycle methods. If you were using them, e.g. super.componentWillReceiveProps, check whether it's still there and use the correct name if needed.
    • Renamed getChildContext* methods to getContext*, e.g. getChildContextName -> getContextName.
    • Synchronous return and throw in onSubmit are no longer allowed. To return an error or some result, return a Promise instead.
    • filterDOMProps.registered is now read-only.
  4. TypeScript
    • A lot of types were added or changed. If you are using TypeScript, you may expect some type errors, as all components are no longer full of any.
    • filterDOMProps.register is now type safe and requires FilterDOMProps interface extension.
  5. Miscellaneous
    • For performance reasons getField, getSubfields, and getType of all bridges are now memoized. If possible, do the same for custom bridges for a potential performance gain.
    • Simplified NumField in most themes as it works as expected in React 16 and later. If you have a custom NumField in your project, do revise its implementation for a potential performance gain.
    • Stop using direct imports and use named ones instead. It'll let your bundler decide, which version it'll need.
      -import BaseForm from 'uniforms/BaseForm';
      +import { BaseForm } from 'uniforms';

@radekmie radekmie moved this from To do to In progress in Open Source (migrated) Nov 30, 2020
Open Source (migrated) automation moved this from In progress to Closed Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

1 participant