Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak #115

Closed
anacrolix opened this issue Sep 10, 2022 · 5 comments
Closed

Memory leak #115

anacrolix opened this issue Sep 10, 2022 · 5 comments
Labels
bug

Comments

@anacrolix
Copy link

When running with 100s of bars (most of which "complete" and stop being updated), memory begins to climb. This behaviour remains even if I Abort my Bars.

image

There's a corresponding increase in CPU use too,

pprof001.

Thanks for the cool library.
@vbauerster vbauerster added the bug label Sep 10, 2022
@vbauerster
Copy link
Owner

Thanks for reporting! I think I know why is that.

vbauerster added a commit that referenced this issue Sep 10, 2022
@vbauerster
address issue #115
717ae08
@vbauerster
Copy link
Owner

Can you please test with head master? Should be fixed.

@vbauerster
Copy link
Owner

Just for reference, the bug introduced in 11d342b. It appears only when bars don't fit to terminal, i.e. number of bars are greater than terminal height.

vbauerster added a commit that referenced this issue Sep 11, 2022
@vbauerster
address issue #115
073ffe9 
minor: var refactoring

minor: wg.Wait err branch

minor: if local var
@anacrolix
Copy link
Author

I'm not sure I can test this now, I've switched to another library for the progress bars and they're deeply integrated into some other changes.

@anacrolix
Copy link
Author

I went back and tried it against master. I cannot reproduce either the memory or CPU problems anymore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anacrolix @vbauerster