Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lookups #7

Merged
merged 8 commits into from Sep 10, 2019

Conversation

@nafallo
Copy link
Member

commented Sep 10, 2019

No description provided.

nafallo added 7 commits Sep 10, 2019
Rewrite ensuring md5sum.txt
Since we were using a lookup to run md5sum on the
files, this only works when building on localhost.

We are now using the find module for listing files
in /extras. The result in addition to the template
loop file list is then fed to a stat loop, which
will save the md5sum. That then replaces the loop
for lineinfile that ensures md5sum.txt is correct.
Use InRelease file instead of Release
Since Release files may become obsolete in future,
we make the change to using InRelease.

In addition we rework the tasks to slurp the file
to avoid pipe lookups, and also rework how we read
the Packages.gz files for the same reason.
Replace lookups in template files
Replace using lookups to read /boot/grub/grub.cfg
and /preseed/ubuntu.seed with slurping the files
in the main playbook and then using the variables.

Reworked the ugly pipe command in grub.cfg to use
a regex_replace to do the same work cleaner.
Remove workaround for re-labelled initrd files
Latest upstream milestones images seem to have
these named just initrd again.
Remove buildiso_preseed_file and rewrite template
The variable buildiso_preseed_file is removed. If
you want to include a full file, use a lookup to
read the file into the buildiso_preseed_content
variable.

Rewrote the template to simplify the stanza, and
update the README.md file to this effect.

@nafallo nafallo added the enhancement label Sep 10, 2019

@nafallo nafallo requested a review from rickardbackman Sep 10, 2019

@nafallo nafallo self-assigned this Sep 10, 2019

@nafallo nafallo force-pushed the nafallo:remove-lookups branch from 707607d to f03116c Sep 10, 2019

@nafallo nafallo requested a review from marbud0 Sep 10, 2019

@rickardbackman
Copy link
Contributor

left a comment

Looks like a better way to do the md5sums.

@rickardbackman rickardbackman merged commit a0432a9 into vcc-caeit:master Sep 10, 2019

@nafallo nafallo deleted the nafallo:remove-lookups branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.