Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2377 "Seer Empty Text" #162

Merged
merged 1 commit into from Jan 27, 2016
Merged

Conversation

@vmarkovtsev
Copy link
Contributor

vmarkovtsev commented Jan 20, 2016

@DjWarmonger

This comment has been minimized.

Copy link
Member

DjWarmonger commented Jan 20, 2016

It breaks the savegame as far as I see.

@vmarkovtsev

This comment has been minimized.

Copy link
Contributor Author

vmarkovtsev commented Jan 20, 2016

Yes, It should - because before the fix the message was actually absent at all. We can generate it randomly each time a hero makes a visit, but looks like original H3 memorize the text, right?

@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Jan 20, 2016

"completedOption" Serialization is missing

@vmarkovtsev vmarkovtsev force-pushed the vmarkovtsev:issue/2377 branch from 997a9ec to f0b0d58 Jan 21, 2016
@vmarkovtsev

This comment has been minimized.

Copy link
Contributor Author

vmarkovtsev commented Jan 21, 2016

Missed that. Added.

@vmarkovtsev

This comment has been minimized.

Copy link
Contributor Author

vmarkovtsev commented Jan 27, 2016

Added new version format, so that it is compatible with older saves. I set it to 757, so it should be merged after #175.

@vmarkovtsev vmarkovtsev force-pushed the vmarkovtsev:issue/2377 branch from 235acad to 0ac833c Jan 27, 2016
ArseniyShestakov added a commit that referenced this pull request Jan 27, 2016
Fix 2377 "Seer Empty Text"
@ArseniyShestakov ArseniyShestakov merged commit ac0187d into vcmi:develop Jan 27, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ArseniyShestakov

This comment has been minimized.

Copy link
Member

ArseniyShestakov commented Jan 27, 2016

Sorry, I must tested it with new game. There is crash in CGSeerHut::initObj 😥
Problem occur when object don't have any mission by default, e.g on my V4 map.

@vmarkovtsev

This comment has been minimized.

Copy link
Contributor Author

vmarkovtsev commented Jan 27, 2016

Oops sorry, I will fix it asap.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member

ArseniyShestakov commented Jan 27, 2016

No worries, in case you don't have time right let me know and I'll fix it.
I sent you map and also uploaded it on bug tracker.

@vmarkovtsev

This comment has been minimized.

Copy link
Contributor Author

vmarkovtsev commented Jan 27, 2016

I am unable to reproduce the crash on the attached map. I visited every Seer Hut and still no crash. What's the stack trace?

@ArseniyShestakov

This comment has been minimized.

Copy link
Member

ArseniyShestakov commented Jan 27, 2016

Can you try with V4 or at least several times?

Problem basically occur because CGQuestGuard overload ::init() function and completedOption may contain random data.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member

ArseniyShestakov commented Jan 27, 2016

Anyway don't worry about that, I'll commit fix now.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member

ArseniyShestakov commented Jan 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.