New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1916 water wheel reward #182

Merged
merged 1 commit into from Jan 30, 2016

Conversation

Projects
None yet
2 participants
@vmarkovtsev
Contributor

vmarkovtsev commented Jan 30, 2016

if(ID == Obj::WATER_WHEEL && what == ObjProperty::REWARD_RESET)
{
auto& reward = info[0].reward.resources[Res::GOLD];
if(info[0].numOfGrants == 0)

This comment has been minimized.

@DjWarmonger

DjWarmonger Jan 30, 2016

Member

Interesting solution. I think this check is not needed since this funtion won't be called on day 1 anyway.

@DjWarmonger

DjWarmonger Jan 30, 2016

Member

Interesting solution. I think this check is not needed since this funtion won't be called on day 1 anyway.

This comment has been minimized.

@vmarkovtsev

vmarkovtsev Jan 30, 2016

Contributor

This check is actually needed: if there was no visits on the previous week (every Monday numOfGrants is set to 0, on each visit it ++), we increase the reward to 1000 on this week.

@vmarkovtsev

vmarkovtsev Jan 30, 2016

Contributor

This check is actually needed: if there was no visits on the previous week (every Monday numOfGrants is set to 0, on each visit it ++), we increase the reward to 1000 on this week.

This comment has been minimized.

@DjWarmonger

DjWarmonger Jan 30, 2016

Member

Ok got it :)

@DjWarmonger

DjWarmonger Jan 30, 2016

Member

Ok got it :)

DjWarmonger added a commit that referenced this pull request Jan 30, 2016

@DjWarmonger DjWarmonger merged commit ab27464 into vcmi:develop Jan 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment