Update secondary skill handling. Fix issue 2307 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also making secondary skill icon display behavior same as in H3 during popup message.
DjWarmonger
requested changes
Sep 19, 2016
| @@ -68,32 +68,51 @@ void CGPandoraBox::giveContentsUpToExp(const CGHeroInstance *h) const | |||
|
|
|||
| if(gainedExp || changesPrimSkill || abilities.size()) | |||
| { | |||
| std::vector<SecondarySkill> unpossessedAbilities; | |||
There was a problem hiding this comment.
I suggest std::pair<Secondary Skill, int>
| int abilitiesRequiringSlot = 0; | ||
|
|
||
| //filter out unnecessary secondary skills | ||
| for (int i = 0; i < abilities.size(); i++) |
| iw.components.push_back(Component(Component::SEC_SKILL,abilities[i],abilityLevels[i],0)); | ||
|
|
||
| cb->showInfoDialog(&iw); | ||
| for(int i=0; i<unpossessedAbilities.size(); i++) |
There was a problem hiding this comment.
same - auto will give shorter code
|
@DjWarmonger can you please clarify how exactly you expect to use auto in that case? He actually use "i" to access multiple different vectors and this looks like reasonable approach to me if we don't want to change object serialization. |
|
Ok I got it. It's actually possible to use auto some of loops if he won't duplicate object properites structure there and just use std::pair. Agree on it. |
|
Thank you very much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also making secondary skill icon display behavior same as in H3 during popup message.