Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build on libboost 1.69.0 #541

Merged
merged 6 commits into from Jan 24, 2019

Conversation

@ilmikko
Copy link
Contributor

commented Jan 24, 2019

The build seems to be broken with the new boost library.
This is caused by the implicit conversions of boost::logic::tribool into bool in the files below.
Explicit casting seems to fix the issue; PR to fix the build.

Built on: g++ 8.2.1 20181127
Libboost version: 1.69.0

ilmikko added some commits Jan 24, 2019

@alexvins alexvins merged commit ccd4169 into vcmi:develop Jan 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexvins

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Thank you for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.