Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few more usages of thread shared ai and cb #552

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
2 participants
@nullkiller
Copy link
Contributor

nullkiller commented Feb 16, 2019

That should be all. Hope no more usages of thread shared ai and cb left in pathfinding.

Show resolved Hide resolved AI/VCAI/Pathfinding/AINodeStorage.cpp Outdated
Show resolved Hide resolved AI/VCAI/Pathfinding/AINodeStorage.h Outdated

@nullkiller nullkiller force-pushed the nullkiller:ai-pathfinder-fix-crash branch from 410c7ef to 24d3d0a Feb 16, 2019

@@ -45,7 +45,7 @@ TSubgoal VisitHero::whatToDoToAchieve()

if(hero && ai->isAccessibleForHero(pos, hero, true) && isSafeToVisit(hero, pos)) //enemy heroes can get reinforcements
{
if(hero->pos == pos)
if(hero->visitablePos() == pos)

This comment has been minimized.

@nullkiller

nullkiller Feb 16, 2019

Author Contributor

Small bug fix of 3036

@nullkiller nullkiller force-pushed the nullkiller:ai-pathfinder-fix-crash branch from 24d3d0a to f76c6c2 Feb 17, 2019

@alexvins alexvins merged commit 35ec9b3 into vcmi:develop Feb 17, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.