FreeBSD and HURD support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the variable is only used to enable XDG support - XDG is not exclusive to linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It seems that the existing preprocessor variable VCMI_LINUX is only used to switch XDG support on and off. But linux is only the kernel and no description for the userland (which you already realized because of the special casing you do for android) and in addition XDG is not limited to linux. So a better fitting name for that preprocessor variable would be VCMI_XDG which would be switched on on platforms with XDG support. Some linux based platforms are part of those. The BSDs and GNU/HURD based systems are others.
Building on top of that it seems that vcmi builds with only minor modifications on kFreeBSD and HURD. This pull request implements those changes.