Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no player interface swap on being attacked #583

Merged
merged 1 commit into from May 4, 2019

Conversation

Projects
None yet
3 participants
@dydzio0614
Copy link
Member

commented May 3, 2019

@ArseniyShestakov

This comment has been minimized.

Copy link
Member

commented May 3, 2019

BTW there still two bugs remaining:

  • Notifications for player still not arrive. E.g if you stand on cursed ground and cant cast spells there is no notifications.
  • When battle starts control over units not given to player, they not highlighted until you click somewhere on battlefield.

I'm fine with merging this since it's improve it greatly already (you can actually control units and cast spells!), but you might want to fix those too.

cmp.push_back(std::make_shared<CComponent>(CComponent::flag, playerID.getNum(), 0));
makingTurn = true; //workaround for stiff showInfoDialog implementation
showInfoDialog(msg, cmp);
makingTurn = false;

This comment has been minimized.

Copy link
@ArseniyShestakov

ArseniyShestakov May 3, 2019

Member

With those 3 lines you bypassed problem for this exact particular case, but all other notifications during battle still hidden from attacked player.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Ok dydzio have asked this to be merged and it does make sense since it's actually make battle playable.
Added separate issue to BT for other issues:
https://bugs.vcmi.eu/view.php?id=3054

@ArseniyShestakov ArseniyShestakov merged commit 54e6e42 into vcmi:develop May 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.