Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Neutral Creatures Weekly Growth #587

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@Ewilhan
Copy link
Contributor

commented May 6, 2019

Made it so neutral creatures could not be picked as "Flavour of the Week".
It is checking neutral creatures hometown to do so.

Fixes #3046.

{
newMonster.second = VLC->creh->pickRandomMonster(getRandomGenerator());
} while (VLC->creh->creatures[newMonster.second] &&
VLC->townh->factions[VLC->creh->creatures[newMonster.second]->faction]->town == nullptr); // find first non neutral creature

This comment has been minimized.

Copy link
@nullkiller

nullkiller May 6, 2019

Collaborator

Do we use newMonster.first somehow? Could we have newMonster variable just of type CreatureID

Fix Neutral Creatures Weekly Growth
Made it so neutral creatures could not be picked as "Flavour of the Week".
It is checking neutral creatures hometown to do so.

Fixes #3046.

@alexvins alexvins merged commit a7cd668 into vcmi:develop May 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.